Fix: Excessive GC CPU pressure caused by unwanted heap memory #281#284
Merged
Sean-Der merged 1 commit intopion:masterfrom Oct 28, 2024
Merged
Fix: Excessive GC CPU pressure caused by unwanted heap memory #281#284Sean-Der merged 1 commit intopion:masterfrom
Sean-Der merged 1 commit intopion:masterfrom
Conversation
Member
|
Fantastic, thank you so much @nithu1991 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #284 +/- ##
==========================================
- Coverage 72.87% 71.13% -1.74%
==========================================
Files 80 80
Lines 3679 4476 +797
==========================================
+ Hits 2681 3184 +503
- Misses 865 1157 +292
- Partials 133 135 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
NACK storage would use a sync.Pool to reduce memory pressure. The new distinict SSRC feature did not properly use this pool. This change updates the RTPBuffer to use it for both paths. Fixes pion#281
62354a9 to
94457ee
Compare
Sean-Der
approved these changes
Oct 28, 2024
Member
|
I have invited you and your co-worker @nithu1991. I am excited to see what else you can improve :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix Excessive GC Pressure due,
interceptor/internal/rtpbuffer/packet_factory.go
Line 94 in d34a3c5
interceptor/internal/rtpbuffer/packet_factory.go
Line 96 in d34a3c5
Reference issue
Fixes #281