Skip to content

Upgrade golangci-lint, more linters#755

Merged
JoTurk merged 1 commit intomasterfrom
upgrade/lint
Jan 17, 2025
Merged

Upgrade golangci-lint, more linters#755
JoTurk merged 1 commit intomasterfrom
upgrade/lint

Conversation

@JoTurk
Copy link
Copy Markdown
Member

@JoTurk JoTurk commented Jan 17, 2025

Description

Introduces new linters, upgrade golangci-lint to version (v1.63.4)

Reference issue

pion/.goassets#220

Introduces new linters, upgrade golangci-lint to version (v1.63.4)
@JoTurk JoTurk mentioned this pull request Jan 17, 2025
20 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 68.81890% with 198 lines in your changes missing coverage. Please review.

Project coverage is 78.54%. Comparing base (647b978) to head (cad1676).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
gather.go 39.58% 56 Missing and 2 partials ⚠️
tcp_mux.go 20.40% 39 Missing ⚠️
agent.go 78.97% 27 Missing and 10 partials ⚠️
selection.go 77.46% 10 Missing and 6 partials ⚠️
candidate_base.go 80.43% 7 Missing and 2 partials ⚠️
agent_config.go 82.85% 6 Missing ⚠️
agent_stats.go 50.00% 5 Missing and 1 partial ⚠️
udp_mux.go 66.66% 4 Missing and 1 partial ⚠️
active_tcp.go 60.00% 4 Missing ⚠️
net.go 63.63% 2 Missing and 2 partials ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
- Coverage   80.01%   78.54%   -1.47%     
==========================================
  Files          41       41              
  Lines        5023     5323     +300     
==========================================
+ Hits         4019     4181     +162     
- Misses        775      912     +137     
- Partials      229      230       +1     
Flag Coverage Δ
go 78.54% <68.81%> (-1.47%) ⬇️
wasm 26.99% <12.12%> (-0.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoTurk JoTurk merged commit cad1676 into master Jan 17, 2025
@JoTurk JoTurk deleted the upgrade/lint branch January 17, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant