Skip to content

Upgrade golangci-lint, more linters#74

Merged
JoTurk merged 1 commit intomasterfrom
impr/lint
Jan 22, 2025
Merged

Upgrade golangci-lint, more linters#74
JoTurk merged 1 commit intomasterfrom
impr/lint

Conversation

@JoTurk
Copy link
Copy Markdown
Member

@JoTurk JoTurk commented Jan 22, 2025

Description

Introduces new linters, upgrade golangci-lint to version (v1.63.4)

Reference issue

pion/.goassets#220

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 79.62963% with 11 lines in your changes missing coverage. Please review.

Project coverage is 66.88%. Comparing base (fd099d9) to head (ed90aa6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/sdp/unmarshal.go 58.33% 5 Missing ⚠️
internal/sdp/scanner.go 0.00% 3 Missing ⚠️
internal/result/peer_details.go 96.96% 1 Missing ⚠️
peerconnection_explainer.go 50.00% 1 Missing ⚠️
pkg/output/output.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   66.05%   66.88%   +0.82%     
==========================================
  Files          10       10              
  Lines         439      462      +23     
==========================================
+ Hits          290      309      +19     
- Misses        141      145       +4     
  Partials        8        8              
Flag Coverage Δ
go 66.88% <79.62%> (+0.82%) ⬆️
wasm 37.22% <74.07%> (+2.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Introduces new linters, upgrade golangci-lint to version (v1.63.4)
@JoTurk JoTurk merged commit ed90aa6 into master Jan 22, 2025
@JoTurk JoTurk deleted the impr/lint branch January 22, 2025 19:07
@JoTurk JoTurk mentioned this pull request Jan 22, 2025
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant