Add Ciphersuite Benchmark Tests#781
Merged
adrianosela merged 1 commit intopion:masterfrom Jan 21, 2026
Merged
Conversation
3d82c43 to
392c031
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #781 +/- ##
==========================================
+ Coverage 81.60% 81.65% +0.05%
==========================================
Files 105 105
Lines 5837 5837
==========================================
+ Hits 4763 4766 +3
+ Misses 690 688 -2
+ Partials 384 383 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fc3797c to
422c5ca
Compare
JoTurk
approved these changes
Jan 21, 2026
Member
JoTurk
left a comment
There was a problem hiding this comment.
Had fun reading this, thank you :)
| encCopy := make([]byte, len(encrypted)) | ||
| copy(encCopy, encrypted) | ||
|
|
||
| _, err := cbcCipher.Decrypt(recordlayer.Header{}, encCopy) |
Member
There was a problem hiding this comment.
I think it would be appropriate to use a non-empty header.
Adds benchmark tests and benchmarking/profiling documentation for CCM, GCM, and CBC (all in pkg/crypto/ciphersuite package).
422c5ca to
434b089
Compare
Contributor
Author
|
Re ran benchmarks with non empty header: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Ciphersuite Benchmark Tests
Adds benchmark tests and benchmarking/profiling documentation for CCM, GCM, and CBC (all in
pkg/crypto/ciphersuitepackage).I have some small throughput and memory improvements I want to open a PR for, but the changes are small and would be easier to review if all this is already present.
Current Results: