Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #764 +/- ##
==========================================
+ Coverage 81.26% 81.27% +0.01%
==========================================
Files 101 101
Lines 5603 5602 -1
==========================================
Hits 4553 4553
+ Misses 676 675 -1
Partials 374 374
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6db18e0 to
d3387e3
Compare
| out := make([]byte, handshakeMessageClientHelloVariableWidthStart) | ||
| out[0] = m.Version.Major | ||
| out[1] = m.Version.Minor | ||
| copy(out[0:2], []byte{m.Version.Major, m.Version.Minor}) |
There was a problem hiding this comment.
Nit: even if it will prob never matter performance wise, and will likely be optimized by the compiler, the temporary slice is unnecessary. even if we'll have to add nolint. would prefer something like out[0], out[1] = m.Version.Major, m.Version.Minor // nolint...
but that's up to you.
There was a problem hiding this comment.
yeah that's a good point, fixed it! thank you!
Add nolint directives for safe slice accesses where bounds are guaranteed by fixed-size arrays or prior bounds checks.
d3387e3 to
4ccbed6
Compare
Add nolint directives for safe slice accesses where bounds are guaranteed by fixed-size arrays or prior bounds checks.