Handshake fragments assembly refactoring#762
Conversation
trs00
commented
Dec 15, 2025
- Determining the end of the fragment by looking at the fragment length, rather than handshake header's length
- Using totalBufferSize to avoid walks the linked list to determine the total buffer size
- Using totalFragmentCount to avoid list grow to an unbounded size with 0-length fragments
- Removing the need to try to reassemble(by recursively calling a function for each fragment) on every new packet
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #762 +/- ##
==========================================
+ Coverage 81.16% 81.26% +0.09%
==========================================
Files 101 101
Lines 5597 5603 +6
==========================================
+ Hits 4543 4553 +10
+ Misses 678 676 -2
+ Partials 376 374 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you so much @trs00! Changes look great to me. Would you be able/interested in fixing the lints? If you don't have time I am happy to push to your branch directly :) |
|
@Sean-Der thanks a lot for looking into PR, I pushed lint fixes |
|
@joeturki may I ask if merge option is not available due to access restrictions or it is necessary to have 100% Patch coverage? |
|
@trs00 Hello, I squash merged, If you plan to make more changes, I can send you an invite to the org so you can make branches directly, and merge PRs after approval :) Thank you a lot. |