Skip to content

Update Kotlin development version to 1.7.20-beta / 1.7.10#1584

Merged
paul-dingemans merged 15 commits intopinterest:masterfrom
paul-dingemans:kotlin-1.7.20-beta
Aug 17, 2022
Merged

Update Kotlin development version to 1.7.20-beta / 1.7.10#1584
paul-dingemans merged 15 commits intopinterest:masterfrom
paul-dingemans:kotlin-1.7.20-beta

Conversation

@paul-dingemans
Copy link
Copy Markdown
Collaborator

@paul-dingemans paul-dingemans commented Aug 14, 2022

Description

Update Kotlin development version to 1.7.20-beta and Kotlin version to 1.7.10.

Checklist

  • PR description added
  • tests are added
  • KtLint has been applied on source code itself and violations are fixed
  • documentation is updated
  • CHANGELOG.md is updated

In case of adding a new rule:

@paul-dingemans
Copy link
Copy Markdown
Collaborator Author

paul-dingemans commented Aug 14, 2022

@Goooler May I kindly request your help with this issue?

Accodirding to https://github.com/pinterest/ktlint/runs/7827127989?check_suite_focus=true:

xecution failed for task ':buildSrc:generateExternalPluginSpecBuilders'.
> Task :buildSrc:generateExternalPluginSpecBuilders FAILED
> Dependency verification failed for configuration ':buildSrc:compileClasspath'
  2 artifacts failed verification:
    - kotlin-gradle-plugin-1.7.[20](https://github.com/pinterest/ktlint/runs/7827127989?check_suite_focus=true#step:7:21)-Beta-gradle71.jar (org.jetbrains.kotlin:kotlin-gradle-plugin:1.7.20-Beta) from repository MavenRepo
    - kotlin-gradle-plugin-api-1.7.20-Beta-gradle71.jar (org.jetbrains.kotlin:kotlin-gradle-plugin-api:1.7.20-Beta) from repository MavenRepo
  If the artifacts are trustworthy, you will need to update the gradle/verification-metadata.xml file by following the instructions at https://docs.gradle.org/7.4/userguide/dependency_verification.html#sec:troubleshooting-verification
  
  Open this report for more details: file:///home/runner/work/ktlint/ktlint/build/reports/dependency-verification/at-1660487803962/dependency-verification-report.html

I do understand that I need to add something to verification-metadata.xml, but I don't know what. I have tried to regenerate this files but this result in expanding the file from 326 lines to 2000+ lines. Any help, especially some explanation of how to resolve it myself would be appreciated.

@Goooler
Copy link
Copy Markdown
Contributor

Goooler commented Aug 15, 2022 •
edited
Loading

Try ./gradlew --write-verification-metadata pgp,sha256 help, and you also need to bump the kotlin version in version catalog, I'm addressing the fix to paul-dingemans#4.

@Goooler Goooler mentioned this pull request Aug 15, 2022
Merged
@paul-dingemans paul-dingemans added this to the 0.47.0 milestone Aug 16, 2022
@Goooler
Copy link
Copy Markdown
Contributor

Goooler commented Aug 17, 2022

@paul-dingemans I tested this PR in Goooler#29, you can revert changes after b2a2041, and pick up 0510a0b to try again.

@Goooler Goooler mentioned this pull request Aug 17, 2022
Closed
@paul-dingemans
Copy link
Copy Markdown
Collaborator Author

paul-dingemans commented Aug 17, 2022

@Goooler Cool, it finally worked. Tnx for helping out! I am gonna try again with next Kotlin update where I can manage it without your help.

@paul-dingemans paul-dingemans merged commit c3ac870 into pinterest:master Aug 17, 2022
@paul-dingemans paul-dingemans deleted the kotlin-1.7.20-beta branch August 17, 2022 18:07
@Goooler Goooler mentioned this pull request Mar 25, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.47.0

Development

Successfully merging this pull request may close these issues.

2 participants

@paul-dingemans @Goooler