Remove Codex service tier option from settings, contracts, and turn dispatch#700
Merged
juliusmarminge merged 2 commits intomainfrom Mar 9, 2026
Merged
Conversation
- Drop `serviceTier` from orchestration/provider contracts and server dispatch paths - Remove service-tier app setting/UI and related resolver logic - Keep fast badge behavior tied to explicit fast-mode boolean
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
- delete `shouldShowFastTierIcon` and its test - remove Zap icon badges from slash model commands and provider model picker - simplify related ChatView props and memo dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Already have fast mode in model picker and this causes out-of-synced state:
Summary
serviceTierfrom orchestration and provider contracts (ThreadTurnStart*, provider session/turn inputs, andProviderServiceTierschema/type).serviceTierthrough server orchestration flow and Codex adapter turn dispatch.Testing
apps/web/src/appSettings.test.tsforshouldShowFastTierIconboolean fast-mode behavior.bun lint.bun typecheck.bun run test.Note
Medium Risk
Medium risk because it removes the
serviceTierfield from shared orchestration/provider contracts and from turn/session dispatch, which can break any callers still sending/expecting that property. Changes span web UI, server orchestration, and provider adapter boundaries, so mismatches will surface at runtime if any integration is missed.Overview
Removes
serviceTierfrom orchestration commands/events and provider API schemas (including deletingProviderServiceTier) and stops propagating it through the server orchestration flow (decider,ProviderCommandReactor) and Codex adapter turn dispatch.Simplifies the web app by deleting the Codex service-tier setting/UI and the fast-tier badge logic tied to that setting; chat turn dispatch no longer includes
serviceTier, and related unit tests are updated accordingly.Written by Cursor Bugbot for commit e5cdd46. This will update automatically on new commits. Configure here.
Note
Remove service tier handling across server orchestration, Codex adapter, web UI, and contracts to eliminate Codex service tier options from settings and turn dispatch
Strip
serviceTierfrom orchestration commands/events, provider session/turn inputs, Codex adaptersendTurnforwarding, and web UI/settings, and update call sites to passundefinedprovider options; see ProviderCommandReactor.ts, decider.ts, CodexAdapter.ts, and contract schemas in orchestration.ts and provider.ts.📍Where to Start
Start with
orchestration.Layers.ProviderCommandReactor.ensureSessionForThreadandsendTurnForThreadin ProviderCommandReactor.ts, then review contract schema removals in orchestration.ts.Macroscope summarized e5cdd46.