Fix NaN comparator skipping tiebreaker in project sorting

cursoragent · cursoragent · commit 659ca5e71bcd · 2026-03-24T18:49:37.000Z
When both projects lack timestamps and have no threads, getProjectSortTimestamp
returns NEGATIVE_INFINITY for both. Subtracting NEGATIVE_INFINITY - NEGATIVE_INFINITY
yields NaN, and since NaN !== 0 is true, the comparator returned NaN instead of
falling through to the name/id tiebreaker. Add Number.isNaN guard to the condition.
diff --git a/apps/web/src/components/Sidebar.logic.ts b/apps/web/src/components/Sidebar.logic.ts
@@ -270,7 +270,7 @@ export function sortProjectsForSidebar<TProject extends SidebarProject, TThread
     const byTimestamp =
       getProjectSortTimestamp(right, threadsByProjectId.get(right.id) ?? [], sortOrder) -
       getProjectSortTimestamp(left, threadsByProjectId.get(left.id) ?? [], sortOrder);
-    if (byTimestamp !== 0) return byTimestamp;
+    if (byTimestamp !== 0 && !Number.isNaN(byTimestamp)) return byTimestamp;
     return left.name.localeCompare(right.name) || left.id.localeCompare(right.id);
   });
 }

Original file line number	Diff line number	Diff line change
`@@ -270,7 +270,7 @@ export function sortProjectsForSidebar<TProject extends SidebarProject, TThread`
`270`	`270`	`const byTimestamp =`
`271`	`271`	`getProjectSortTimestamp(right, threadsByProjectId.get(right.id) ?? [], sortOrder) -`
`272`	`272`	`getProjectSortTimestamp(left, threadsByProjectId.get(left.id) ?? [], sortOrder);`
`273`		`- if (byTimestamp !== 0) return byTimestamp;`
	`273`	`+ if (byTimestamp !== 0 && !Number.isNaN(byTimestamp)) return byTimestamp;`
`274`	`274`	`return left.name.localeCompare(right.name) \|\| left.id.localeCompare(right.id);`
`275`	`275`	`});`
`276`	`276`	`}`