Short-circuit findOpenPr after first matching PR is found

cursoragent · juliusmarminge · cursoragent · commit 3fc5bdf5bcb3 · 2026-03-10T17:47:54.000Z
Avoid unnecessary GitHub API calls by returning immediately when a PR
is found from the first matching headSelector, instead of iterating
through all selectors and discarding the results.

Co-authored-by: Julius Marminge &lt;juliusmarminge@users.noreply.github.com&gt;
diff --git a/apps/server/src/git/Layers/GitManager.ts b/apps/server/src/git/Layers/GitManager.ts
@@ -528,8 +528,6 @@ export const makeGitManager = Effect.gen(function* () {
 
   const findOpenPr = (cwd: string, headSelectors: ReadonlyArray<string>) =>
     Effect.gen(function* () {
-      const parsedByNumber = new Map<number, PullRequestInfo>();
-
       for (const headSelector of headSelectors) {
         const pullRequests = yield* gitHubCli.listOpenPullRequests({
           cwd,
@@ -538,20 +536,19 @@ export const makeGitManager = Effect.gen(function* () {
         });
 
         for (const pr of pullRequests) {
-          parsedByNumber.set(pr.number, {
+          return {
             number: pr.number,
             title: pr.title,
             url: pr.url,
             baseRefName: pr.baseRefName,
             headRefName: pr.headRefName,
             state: "open",
             updatedAt: null,
-          } satisfies PullRequestInfo);
+          } satisfies PullRequestInfo;
         }
       }
 
-      const [first] = parsedByNumber.values();
-      return first ?? null;
+      return null;
     });
 
   const findLatestPr = (cwd: string, details: { branch: string; upstreamRef: string | null }) =>
