cluster: add support of TLS encryption for TiDB cluster#673
Merged
lucklove merged 13 commits intopingcap:masterfrom Sep 3, 2020
Merged
cluster: add support of TLS encryption for TiDB cluster#673lucklove merged 13 commits intopingcap:masterfrom
lucklove merged 13 commits intopingcap:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #673 +/- ##
==========================================
+ Coverage 58.07% 58.77% +0.70%
==========================================
Files 255 257 +2
Lines 18904 19439 +535
==========================================
+ Hits 10978 11425 +447
- Misses 6473 6499 +26
- Partials 1453 1515 +62
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
fad3866 to
4621518
Compare
c0b4fa0 to
87d43bd
Compare
0b90913 to
ecfa558
Compare
7faa9fc to
fc3ccf0
Compare
july2993
reviewed
Aug 24, 2020
Contributor
july2993
left a comment
There was a problem hiding this comment.
Error: failed to transfer CA cert to server: Process exited with status 1
pls fix ci
july2993
reviewed
Aug 24, 2020
july2993
reviewed
Aug 24, 2020
july2993
reviewed
Aug 24, 2020
| // String implements the fmt.Stringer interface | ||
| func (c *TLSCert) String() string { | ||
| return fmt.Sprintf("TLSCert: host=%s role=%s cn=%s", | ||
| c.inst.GetHost(), c.inst.Role(), c.inst.ComponentName()) |
Contributor
There was a problem hiding this comment.
Role alway = ComponentName ?
Contributor
Author
There was a problem hiding this comment.
No it's for example tispark-master as role and tispark as component name, identical for most components but not all.
| if !ok { | ||
| return ErrNoExecutor | ||
| } | ||
| if err := e.Transfer(caFile, |
Contributor
There was a problem hiding this comment.
seems this API should be designed as Transfer and Download at first. (not block this pr)
ac1f874 to
cb1382b
Compare
Contributor
|
/merge |
Contributor
|
Your auto merge job has been accepted, waiting for:
|
Contributor
|
/run-all-tests |
Contributor
|
@AstroProfundis merge failed. |
Contributor
|
@AstroProfundis Please resolve the conflicts. |
dc0db75 to
1fac178
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add support for TLS encryption for TiDB cluster. Close #529
What is changed and how it works?
displayoutput for TLS enabled clusterCheck List
Tests
Code changes
Side effects
Related changes
Release notes: