Skip to content

TiFlash: Enable and inactive prof when start#2437

Merged
xhebox merged 1 commit intopingcap:masterfrom
CalvinNeo:enable-prof-tiflash
Jul 12, 2024
Merged

TiFlash: Enable and inactive prof when start#2437
xhebox merged 1 commit intopingcap:masterfrom
CalvinNeo:enable-prof-tiflash

Conversation

@CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Jul 11, 2024

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@CalvinNeo
add prof
98ebbd5 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from breezewish July 11, 2024 07:35
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 11, 2024
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Jul 11, 2024

/cc @JaySon-Huang

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 11, 2024

@CalvinNeo: GitHub didn't allow me to request PR reviews from the following users: JaySon-Huang.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @JaySon-Huang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CalvinNeo
Copy link
Member Author

CalvinNeo commented Jul 11, 2024 

Error: download from https://tiup-mirrors.pingcap.com/grafana-v8.2.0-alpha-nightly-linux-amd64.tar.gz failed: read tcp 172.19.0.100:55558->43.152.135.107:443: read: connection reset by peer

@CalvinNeo
Copy link
Member Author

CalvinNeo commented Jul 11, 2024

/retest

@CalvinNeo CalvinNeo mentioned this pull request Jul 11, 2024
Merged
9 tasks
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Jul 11, 2024

/retest

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 12, 2024

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CalvinNeo
Copy link
Member Author

CalvinNeo commented Jul 12, 2024

/cc @xhebox @bb7133

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox July 12, 2024 03:33
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-12 06:48:50.81554493 +0000 UTC m=+599428.050779038: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 12, 2024
@xhebox xhebox merged commit bac3c2e into pingcap:master Jul 12, 2024
@JaySon-Huang JaySon-Huang mentioned this pull request Dec 13, 2024
Open
8 tasks
@JaySon-Huang JaySon-Huang mentioned this pull request Mar 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhebox xhebox xhebox approved these changes

@breezewish breezewish Awaiting requested review from breezewish

@bb7133 bb7133 Awaiting requested review from bb7133

+1 more reviewer

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CalvinNeo @JaySon-Huang @xhebox