Skip to content

docker: Update docker compose image references#9965

Merged
ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom
purelind:purelind/adjust-default-iamge-path-of-it
Mar 10, 2025
Merged

docker: Update docker compose image references#9965
ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom
purelind:purelind/adjust-default-iamge-path-of-it

Conversation

@purelind
Copy link
Contributor

@purelind purelind commented Mar 8, 2025 •
edited
Loading

What problem does this PR solve?

Update docker compose files to use more specific image references with environment variable overrides:

  • Replace hardcoded image paths with configurable image references
  • Add support for custom image selection via environment variables
  • Update the default internal image path for pd, tikv, and tidb services
  • Maintain default images when no custom image is specified

Issue Number: close #9970

Problem Summary:

# The tidb-server binary in "hub.pingcap.net/qa/tidb:master"
[root@248bb25dc770 /]# ./tidb-server -V
Release Version: v8.5.0-alpha
Edition: Community
Git Commit Hash: afe8a09e928c67188cbd94eb033ab17916a3eb3a
Git Branch: heads/refs/tags/v8.5.0-alpha
UTC Build Time: 2024-11-18 11:57:41
GoVersion: go1.23.3
Race Enabled: false
Check Table Before Drop: false
Store: unistore

What is changed and how it works?

Update the default internal image path for pd, tikv, and tidb services

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@purelind
docker: Update docker compose image references
4b04730 
Update docker compose files to use more specific image references with environment variable overrides:
- Replace hardcoded image paths with configurable image references
- Add support for custom image selection via environment variables
- Update image paths for pd, tikv, and tidb services
- Maintain default images when no custom image is specified
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 8, 2025
@purelind purelind changed the title WIP docker: Update docker compose image references docker: Update docker compose image references Mar 10, 2025
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2025
@purelind
Copy link
Contributor Author

purelind commented Mar 10, 2025

/cc @JaySon-Huang @Lloyd-Pottiger

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 10, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 10, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-10 07:22:56.413444201 +0000 UTC m=+167732.018973123: ☑️ agreed by JaySon-Huang.
  • 2025-03-10 07:31:03.996098768 +0000 UTC m=+168219.601627695: ☑️ agreed by Lloyd-Pottiger.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 10, 2025

@purelind: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@purelind
Copy link
Contributor Author

purelind commented Mar 10, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit 8082e9b into pingcap:master Mar 10, 2025
5 checks passed
@JaySon-Huang JaySon-Huang mentioned this pull request Nov 4, 2025
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The image address in the docker-compose file needs to be updated.

3 participants

@purelind @JaySon-Huang @Lloyd-Pottiger