Skip to content

Fix operator new[] and delete mismatch for join probe prefetch states#9938

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
gengliqi:fix-prefetch-delete
Mar 5, 2025
Merged

Fix operator new[] and delete mismatch for join probe prefetch states#9938
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
gengliqi:fix-prefetch-delete

Conversation

@gengliqi
Copy link
Contributor

@gengliqi gengliqi commented Mar 4, 2025

What problem does this PR solve?

Issue Number: close #9937

Problem Summary:

What is changed and how it works?

Fix operator new[] and delete mismatch for join probe prefetch states

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@gengliqi
fix prefetch delete
5934071 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2025
@gengliqi gengliqi requested review from windtalker and yibin87 March 4, 2025 10:35
yibin87
yibin87 approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 5, 2025
windtalker
windtalker approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 5, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-05 01:14:23.672546696 +0000 UTC m=+404176.801466439: ☑️ agreed by yibin87.
  • 2025-03-05 01:28:46.106653797 +0000 UTC m=+405039.235573539: ☑️ agreed by windtalker.

@ti-chi-bot ti-chi-bot bot merged commit 8341d9a into pingcap:master Mar 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@yibin87 yibin87 yibin87 approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

operator new[] and delete mismatch for join probe prefetch states

3 participants

@gengliqi @windtalker @yibin87