FFI: Fix NPE when GetLockByKey is called when region is not exist#9914
Merged
ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom Feb 26, 2025
Merged
FFI: Fix NPE when GetLockByKey is called when region is not exist#9914ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom
ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom
Conversation
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
JaySon-Huang
commented
Feb 26, 2025
| auto restored_segments = checkpoint_info->getRestoredSegments(); | ||
| auto updated_segments = ingestSegmentsUsingSplit(dm_context, range, restored_segments); | ||
| auto estimated_bytes = 0; | ||
| size_t estimated_bytes = 0; |
Contributor
Author
There was a problem hiding this comment.
auto in here unexpectedly lead to negative value because the compiler use int32 for the auto. And collecting the bytes of restored_segment could larger than 2GiB.
JinheLin
approved these changes
Feb 26, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, JinheLin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9915
Problem Summary:
There could be a chance that GetLockByKey is called when region is not exist
And returning
BaseBuffViewto rust is not memory safeWhat is changed and how it works?
Pending on pingcap/tidb-engine-ext#426
Check List
Tests
Side effects
Documentation
Release note