Skip to content

minor refine for column serialize interface#9898

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
guo-shaoge:refine_nullmap_pr
Mar 10, 2025
Merged

minor refine for column serialize interface#9898
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
guo-shaoge:refine_nullmap_pr

Conversation

@guo-shaoge
Copy link
Contributor

@guo-shaoge guo-shaoge commented Feb 21, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9973

Problem Summary: refine some comments and the template name to keep it same with ColumnString.cpp

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@guo-shaoge
minor refine for column serialize interface
d3436a2 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 21, 2025
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 10, 2025
@guo-shaoge
fix
bbe7613 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
xzhangxian1008
xzhangxian1008 approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 10, 2025
yibin87
yibin87 approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xzhangxian1008, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 10, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-10 09:01:20.751545615 +0000 UTC m=+173636.357074543: ☑️ agreed by xzhangxian1008.
  • 2025-03-10 09:11:30.3260334 +0000 UTC m=+174245.931562324: ☑️ agreed by yibin87.

guo-shaoge and others added 2 commits March 10, 2025 17:16
@guo-shaoge
fmt
b5b9cb6 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot
Merge branch 'master' into refine_nullmap_pr
3335577
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 10, 2025

@guo-shaoge: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 93ff0c7 into pingcap:master Mar 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yibin87 yibin87 yibin87 approved these changes

+1 more reviewer

@xzhangxian1008 xzhangxian1008 xzhangxian1008 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

refine template names of serialize method

3 participants

@guo-shaoge @yibin87 @xzhangxian1008