Skip to content

remove OVERFLOW_AS_WARNING flag#9862

Merged
ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom
guo-shaoge:remove_overflow_flag
Feb 11, 2025
Merged

remove OVERFLOW_AS_WARNING flag#9862
ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom
guo-shaoge:remove_overflow_flag

Conversation

@guo-shaoge
Copy link
Contributor

@guo-shaoge guo-shaoge commented Feb 11, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9752

Problem Summary: check description in issue. tidb removed OverflowAsWarning flag, because its semantics is same with TruncateAsWarning

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@guo-shaoge
remove OverflowAsWarning flag
87ec6d3 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Feb 11, 2025
@guo-shaoge
fmt
5c9b8f9 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 11, 2025
@guo-shaoge guo-shaoge changed the title remove OverflowAsWarning flag Unify the semantics of OVERFLOW_AS_WARNING and TRUNCATE_AS_WARNING Feb 11, 2025
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 11, 2025
@guo-shaoge guo-shaoge changed the title Unify the semantics of OVERFLOW_AS_WARNING and TRUNCATE_AS_WARNING remove OVERFLOW_AS_WARNING flag Feb 11, 2025
@guo-shaoge
fix
9eb1dcd 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 11, 2025
windtalker
windtalker approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 11, 2025
xzhangxian1008
xzhangxian1008 approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 11, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 11, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-11 05:15:14.597891353 +0000 UTC m=+333556.994113415: ☑️ agreed by windtalker.
  • 2025-02-11 06:10:05.236324055 +0000 UTC m=+336847.632546117: ☑️ agreed by xzhangxian1008.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 11, 2025

@guo-shaoge: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 607d850 into pingcap:master Feb 11, 2025
5 checks passed
@JaySon-Huang JaySon-Huang deleted the remove_overflow_flag branch February 11, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

+1 more reviewer

@xzhangxian1008 xzhangxian1008 xzhangxian1008 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

for MPP request, tiflash doesn't honor FlagIgnoreTruncate

3 participants

@guo-shaoge @windtalker @xzhangxian1008