Skip to content

Set proxy's memory limit by TiFlash (#9753) and update tiflash proxy#9853

Merged
ti-chi-bot[bot] merged 6 commits intopingcap:release-7.5from
CalvinNeo:cp-memory-7.5
Feb 10, 2025
Merged

Set proxy's memory limit by TiFlash (#9753) and update tiflash proxy#9853
ti-chi-bot[bot] merged 6 commits intopingcap:release-7.5from
CalvinNeo:cp-memory-7.5

Conversation

@CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Feb 8, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9745 ref #4982

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix an issue that TiFlash may unexpectedly reject raft message when memory usage is not high

@CalvinNeo @JaySon-Huang
Set proxy's memory limit by TiFlash (pingcap#9753)
0918afd 
close pingcap#9745

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>

Co-authored-by: JaySon <tshent@qq.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 8, 2025
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Feb 8, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2025
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Feb 8, 2025

Some cherry-pick code does not work under release-7.5 and lead to compile error. Should fix it.

@CalvinNeo
could build now
fb6cced 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@CalvinNeo
reformat
b376c8f 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@CalvinNeo
fix clippy
4897493 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@CalvinNeo
fix
7e403d7 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@CalvinNeo
fix
4b43607 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 10, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 10, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 10, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-10 06:17:26.294632989 +0000 UTC m=+250888.690855051: ☑️ agreed by Lloyd-Pottiger.
  • 2025-02-10 07:48:33.22969155 +0000 UTC m=+256355.625913612: ☑️ agreed by JaySon-Huang.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 10, 2025
@ti-chi-bot ti-chi-bot bot merged commit 7d751d6 into pingcap:release-7.5 Feb 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JinheLin JinheLin Awaiting requested review from JinheLin

Assignees

No one assigned

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CalvinNeo @JaySon-Huang @Lloyd-Pottiger