Skip to content

fix false assert in tiflash debug binary after enable new string serde#9830

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
windtalker:fix_assert_in_debug_build
Jan 24, 2025
Merged

fix false assert in tiflash debug binary after enable new string serde#9830
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
windtalker:fix_assert_in_debug_build

Conversation

@windtalker
Copy link
Contributor

@windtalker windtalker commented Jan 24, 2025 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: close #9824, ref #9673

Problem Summary:

What is changed and how it works?

The root cause is in HashPartitionWriter, it need update mem_size_in_blocks if using partitionAndWriteBlocksV1, and if data_codec_version is MPPDataPacketV2, it use partitionAndWriteBlocksV1 but not update mem_size_in_blocks

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@windtalker
save work
7530c1f 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Jan 24, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 24, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 24, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 24, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-24 07:51:05.25125504 +0000 UTC m=+426392.582174443: ☑️ agreed by Lloyd-Pottiger.
  • 2025-01-24 08:04:14.69177202 +0000 UTC m=+427182.022691423: ☑️ agreed by JinheLin.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 24, 2025

@windtalker: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit a8f72d4 into pingcap:master Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JinheLin JinheLin JinheLin approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TiFlash debug binary failed to run Tpc-H

3 participants

@windtalker @JinheLin @Lloyd-Pottiger