KVStore: Fix unreleased Region instance#9763
Conversation
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
|
/retest |
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
@CalvinNeo: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #9722
Problem Summary:
After a region is split, the new regions are stored in
raft_cmd_reswhose lifetime equals to KVStore. This struct will never be overwritten unless a new region is split.As a result, the region can not be removed, even it is destroyed.
In this PR, we get rid of the
raft_cmd_res, and we can foundRegions can be destructed after it is destroyed.We also added some metrics for further diagnose.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note