support comparison semantics for batch serialize/deserialize of Column#9756
Merged
ti-chi-bot[bot] merged 33 commits intopingcap:masterfrom Jan 22, 2025
Merged
support comparison semantics for batch serialize/deserialize of Column#9756ti-chi-bot[bot] merged 33 commits intopingcap:masterfrom
ti-chi-bot[bot] merged 33 commits intopingcap:masterfrom
Conversation
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
a311faa to
eeb1ac3
Compare
Signed-off-by: guo-shaoge <shaoge1994@163.com>
eeb1ac3 to
c07d13a
Compare
e19c851 to
7c725cb
Compare
Signed-off-by: guo-shaoge <shaoge1994@163.com>
7c725cb to
84ee65b
Compare
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Contributor
Author
|
/retest |
3878b4b to
47cdf91
Compare
gengliqi
reviewed
Jan 17, 2025
gengliqi
reviewed
Jan 20, 2025
dbms/src/Columns/ColumnString.cpp
Outdated
|
|
||
| #ifdef TIFLASH_ENABLE_AVX_SUPPORT | ||
| if (use_nt_align_buffer) | ||
| if constexpr (!add_terminating_zero) |
Contributor
There was a problem hiding this comment.
How about adding a terminating zero in serializeToPos? If so, this branch parameter can be removed and align_buffer can be used as original version.
| size_t maxBytesForOneChar() const override | ||
| { | ||
| // Every char have 8 uint16 at most. | ||
| return 8 * sizeof(uint16_t); |
Contributor
There was a problem hiding this comment.
It seems too large. Is it necessary to use 16 bytes?
bf956af to
80920f3
Compare
gengliqi
reviewed
Jan 22, 2025
ef3c0ea to
ac9b29a
Compare
gengliqi
approved these changes
Jan 22, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gengliqi, yibin87 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Contributor
Author
|
/hold |
Signed-off-by: guo-shaoge <shaoge1994@163.com>
1a0f52a to
f6c8115
Compare
This was referenced Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9761
Problem Summary: #9553 add serialize/deserialize interface by column-wise, but it didn't handle collator for ColumnString and real copy format for ColumnDecimal([sign, limb_count, limb_data])
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note