Skip to content

Fix incompatible behavior with TiDB when casting float into string#9696

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
solotzg:fix-tidb-57652
Dec 5, 2024
Merged

Fix incompatible behavior with TiDB when casting float into string#9696
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
solotzg:fix-tidb-57652

Conversation

@solotzg
Copy link
Contributor

@solotzg solotzg commented Dec 4, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9697
Problem Summary:

What is changed and how it works?

Fix incompatible behavior with TiDB when casting floating into string
- always convert the format into non-exponential representation

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@solotzg
fix tidb/57652
f5a40fc 
Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 4, 2024
@solotzg solotzg changed the title [wip] Fix incompatible behavior with TiDB when casting float into string Dec 4, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue labels Dec 4, 2024
@solotzg
more comments
5a5fca3 
Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
@solotzg
Copy link
Contributor Author

solotzg commented Dec 4, 2024

/run-all-tests

@solotzg solotzg requested review from windtalker and yibin87 December 4, 2024 10:03
windtalker
windtalker reviewed Dec 5, 2024
View reviewed changes
@solotzg
remove useless code
7da8c5e 
Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
windtalker
windtalker approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 5, 2024
yibin87
yibin87 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 5, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-05 05:31:54.620262994 +0000 UTC m=+1305702.239917509: ☑️ agreed by windtalker.
  • 2024-12-05 07:42:14.991714577 +0000 UTC m=+1313522.611369093: ☑️ agreed by yibin87.

@ti-chi-bot ti-chi-bot bot merged commit be0b70a into pingcap:master Dec 5, 2024
@solotzg solotzg deleted the fix-tidb-57652 branch December 5, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@yibin87 yibin87 yibin87 approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incompatible behavior with TiDB when casting float into string

3 participants

@solotzg @windtalker @yibin87