Skip to content

Storage: Fix getSquashDeleteRange does not return correctly squashed key-range when using common-handle (#9530)#9565

Merged
ti-chi-bot[bot] merged 6 commits intopingcap:release-7.1from
ti-chi-bot:cherry-pick-9530-to-release-7.1
Nov 1, 2024
Merged

Storage: Fix getSquashDeleteRange does not return correctly squashed key-range when using common-handle (#9530)#9565
ti-chi-bot[bot] merged 6 commits intopingcap:release-7.1from
ti-chi-bot:cherry-pick-9530-to-release-7.1

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9530

What problem does this PR solve?

Issue Number: close #9529

Problem Summary:

we get the "suqash delete range" to estimate whether there are sufficient delete rows that we need to compact data in background thread.

auto actual_delete_range = snap->delta->getSquashDeleteRange().shrink(segment_range);
if (actual_delete_range.none())
return false;

In ColumnFileSetSnapshot::getSquashDeleteRange, it use the member variable is_common_handle, rowkey_column_size to generate the rowkey range.
But actually those two variable are not set correctly. is_common_handle is always false in ColumnFileSetSnapshot

RowKeyRange ColumnFileSetSnapshot::getSquashDeleteRange() const
{
RowKeyRange squashed_delete_range = RowKeyRange::newNone(is_common_handle, rowkey_column_size);
for (const auto & column_file : column_files)
{
if (auto * f_delete = column_file->tryToDeleteRange(); f_delete)
squashed_delete_range = squashed_delete_range.merge(f_delete->getDeleteRange());
}
return squashed_delete_range;
}

So when the table use common-handle, shouldCompactDeltaWithStable always returns false, and the segment background gc is not GC in timely

What is changed and how it works?

Storage: Fix `getSquashDeleteRange` does not return correctly squashed key-range when using common-handle
  • Remove unused variable ColumnFileSetSnapshot::{is_common_handle, rowkey_column_size}
  • Pass the correct is_common_handle, rowkey_column_size in function shouldCompactDeltaWithStable
  • Add check for rowkey-range is_common_handle in DMFilePackFilter

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Improve the data background GC speed on clustered-index table
提升聚簇索引的表后台回收过期数据的速度

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Oct 29, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 29, 2024
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 1, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 1, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 1, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 1, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-01 08:59:42.609761712 +0000 UTC m=+599495.448917250: ☑️ agreed by JaySon-Huang.
  • 2024-11-01 09:12:00.907064037 +0000 UTC m=+600233.746219583: ☑️ agreed by Lloyd-Pottiger.

@ti-chi-bot ti-chi-bot bot merged commit 1b2a2ea into pingcap:release-7.1 Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants