Fix potential hang issues when fine grained shuffle is enabled#9548
Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom Oct 21, 2024
Merged
Fix potential hang issues when fine grained shuffle is enabled#9548ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
Conversation
gengliqi
approved these changes
Oct 21, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gengliqi, yibin87 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #9413
Problem Summary:
#9424 fix #9413 by "Make sure that each time an ExchangeSenderSinkOp is notified, the ExchangeSenderSinkOp should either write data to LooseBoundedMPMCQueue, or try to notify another ExchangeSenderSinkOp", and actually requires that when
ExchangeSenderSinkOpwrite data toMPPTunnelSetWriter, it will write data to all tunnels inMPPTunnelSetWriter. But for fine grained write, current code may skip the write if some tunnel does not have data to write, this is unexpected, and may make query hang in some extrame cases.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note