Skip to content

Support other integer types for SubstringUTF8 & RightUTF8 functions (#9507)#9510

Merged
ti-chi-bot[bot] merged 7 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-9507-to-release-7.5
Oct 10, 2024
Merged

Support other integer types for SubstringUTF8 & RightUTF8 functions (#9507)#9510
ti-chi-bot[bot] merged 7 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-9507-to-release-7.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Oct 10, 2024

This is an automated cherry-pick of #9507

What problem does this PR solve?

Issue Number: close #9473

Problem Summary:

What is changed and how it works?

Support other integer types for SubstringUTF8 & RightUTF8 functions

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@gengliqi @ti-chi-bot
fix substring & right
c7fc483 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi @ti-chi-bot
add test
1a33c17 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi @ti-chi-bot
remove out-of-date comments
91578c9 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi @ti-chi-bot
address comments
6d10658 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi @ti-chi-bot
u
9fae8d2 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi @ti-chi-bot
fix left test
590df03 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Oct 10, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 10, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 10, 2024
@gengliqi
fix
3b599a3 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
windtalker
windtalker approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 10, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [gengliqi,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 10, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-10 11:25:42.213629419 +0000 UTC m=+1131697.633842430: ☑️ agreed by gengliqi.
  • 2024-10-10 12:02:26.189699257 +0000 UTC m=+1133901.609912269: ☑️ agreed by windtalker.

@purelind
Copy link
Contributor

purelind commented Oct 10, 2024

/retest

1 similar comment
@gengliqi
Copy link
Contributor

gengliqi commented Oct 10, 2024

/retest

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Oct 10, 2024
@gengliqi gengliqi removed the cherry-pick-approved Cherry pick PR approved by release team. label Oct 10, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. labels Oct 10, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 10, 2024

@gengliqi: You cannot manually add or delete the cherry pick approval state labels, only I and the tursted members have permission to do so. You can approve it in internal platform.

Details

In response to removing label named cherry-pick-approved.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 8534177 into pingcap:release-7.5 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@gengliqi gengliqi gengliqi approved these changes

Assignees

@gengliqi gengliqi

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @purelind @gengliqi @windtalker