Skip to content

Storage: Support drop vector index defined on ColumnInfo when column is dropped#9475

Merged
Lloyd-Pottiger merged 4 commits intopingcap:feature/vector-indexfrom
Lloyd-Pottiger:support-drop
Sep 27, 2024
Merged

Storage: Support drop vector index defined on ColumnInfo when column is dropped#9475
Lloyd-Pottiger merged 4 commits intopingcap:feature/vector-indexfrom
Lloyd-Pottiger:support-drop

Conversation

@Lloyd-Pottiger
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #9032

Problem Summary:

What is changed and how it works?

Pick https://github.com/tidbcloud/tiflash-cse/pull/283 and https://github.com/tidbcloud/tiflash-cse/pull/300

  • Unify the logic of generateLocalIndexInfos and initLocalIndexInfos
    • Print 1 logging for the vector index added/dropped/existing in one table instead. This can avoid the flood of logging when tiflash restart with lots of table with vector index defined
    • Support drop the vector index defined on ColumnInfo after the Column has been dropped in TiDB
  • Add more ut in the DeltaMergeStore read level
  • vector search fallback when top_k = max uint32

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants