Skip to content

storage: fix write stable meta twice when SegmentMerge and SegmentSplit#9432

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
Lloyd-Pottiger:fix-meta-twice
Sep 14, 2024
Merged

storage: fix write stable meta twice when SegmentMerge and SegmentSplit#9432
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
Lloyd-Pottiger:fix-meta-twice

Conversation

@Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Sep 14, 2024

What problem does this PR solve?

Issue Number: close #9431 close #7502

Problem Summary:

What is changed and how it works?

storage: fix write stable meta twice when SegmentMerge and SegmentSplit

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 14, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 14, 2024
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Greate job!

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,JinheLin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 14, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-14 06:36:49.794126064 +0000 UTC m=+683879.534550000: ☑️ agreed by JinheLin.
  • 2024-09-14 07:36:27.416088663 +0000 UTC m=+687457.156512603: ☑️ agreed by JaySon-Huang.

@ti-chi-bot ti-chi-bot bot merged commit 9e3ba66 into pingcap:master Sep 14, 2024
@Lloyd-Pottiger Lloyd-Pottiger deleted the fix-meta-twice branch September 14, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

3 participants