Skip to content

update proxy of release-8.1 to raftstore-proxy-8.1#9409

Merged
ti-chi-bot[bot] merged 6 commits intopingcap:release-8.1from
CalvinNeo:update_proxy_20240904_145910
Sep 4, 2024
Merged

update proxy of release-8.1 to raftstore-proxy-8.1#9409
ti-chi-bot[bot] merged 6 commits intopingcap:release-8.1from
CalvinNeo:update_proxy_20240904_145910

Conversation

@CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Sep 4, 2024 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: close #9410 ref #4982, close #9287

Problem Summary:
update proxy to raftstore-proxy-8.1

What is changed and how it works?

update proxy to raftstore-proxy-8.1, which include the BR restore pre-check capabilities

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@CalvinNeo
update tiflash proxy to proxy_up/raftstore-proxy-8.1
bcb0201 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 4, 2024
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Sep 4, 2024

/cc @JaySon-Huang @Lloyd-Pottiger @JinheLin

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 4, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 4, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-04 07:14:54.049379859 +0000 UTC m=+428618.567432777: ☑️ agreed by Lloyd-Pottiger.
  • 2024-09-04 07:23:32.659185493 +0000 UTC m=+429137.177238417: ☑️ agreed by JinheLin.

CalvinNeo and others added 2 commits September 4, 2024 15:56
@CalvinNeo
fix
cb76426 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Merge branch 'release-8.1' into update_proxy_20240904_145910
2c1be8e
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 4, 2024
@CalvinNeo
fix
c922dbe 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Sep 4, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2024
@CalvinNeo
Merge branch 'update_proxy_20240904_145910' of github.com:CalvinNeo/t…
542005c 
…ics into update_proxy_20240904_145910
@CalvinNeo
a
d73122a 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 4, 2024
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Sep 4, 2024

Proxy pingcap/tidb-engine-ext@7dc50b4...5614474

@CalvinNeo
Copy link
Member Author

CalvinNeo commented Sep 4, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2024
JaySon-Huang
JaySon-Huang approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JaySon-Huang JaySon-Huang mentioned this pull request Sep 4, 2024
Closed
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Sep 4, 2024

/run-all-tests

@CalvinNeo
Copy link
Member Author

CalvinNeo commented Sep 4, 2024

DMStoreForSegmentReadTaskTest.FetchPages_Tiny_InMem
https://ci.pingcap.net/blue/rest/organizations/jenkins/pipelines/tiflash-ghpr-unit-tests/runs/13314/log/?start=0
Seems blocked

@CalvinNeo
Copy link
Member Author

CalvinNeo commented Sep 4, 2024

/run-unit-test

@ti-chi-bot ti-chi-bot bot merged commit 4adeb81 into pingcap:release-8.1 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@JinheLin JinheLin JinheLin approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

Assignees

No one assigned

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CalvinNeo @JaySon-Huang @JinheLin @Lloyd-Pottiger