Skip to content

Improve the performance of length and ascii functions (#9345)#9398

Closed
ti-chi-bot wants to merge 9 commits intopingcap:release-5.4from
ti-chi-bot:cherry-pick-9345-to-release-5.4
Closed

Improve the performance of length and ascii functions (#9345)#9398
ti-chi-bot wants to merge 9 commits intopingcap:release-5.4from
ti-chi-bot:cherry-pick-9345-to-release-5.4

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9345

What problem does this PR solve?

Issue Number: close #9344

Problem Summary:

What is changed and how it works?

Benchmark from bench_function_string.cpp

           origin         optimized
length    19794917 ns    1824123 ns 985.2%
ascii     20572895 ns    2592171 ns 693.7%

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Sep 3, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. labels Sep 3, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 3, 2024
@xzhangxian1008
Copy link
Contributor

/rebuild

@xzhangxian1008
Copy link
Contributor

/run-all-tests

@xzhangxian1008
Copy link
Contributor

/run-all-tests

@xzhangxian1008
Copy link
Contributor

/run-unit-test

@xzhangxian1008
Copy link
Contributor

/run-all-tests

@xzhangxian1008
Copy link
Contributor

/run-unit-test

@xzhangxian1008
Copy link
Contributor

/run-all-tests

@xzhangxian1008
Copy link
Contributor

/run-unit-test

@xzhangxian1008
Copy link
Contributor

/run-unit-test

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 6, 2024
@xzhangxian1008
Copy link
Contributor

/run-all-tests

@xzhangxian1008
Copy link
Contributor

/close

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 6, 2024

@xzhangxian1008: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot closed this Sep 6, 2024
@ti-chi-bot ti-chi-bot deleted the cherry-pick-9345-to-release-5.4 branch April 15, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants