Skip to content

fix cast to decimal wrong sign (#9300)#9356

Merged
ti-chi-bot[bot] merged 6 commits intopingcap:release-8.1from
ti-chi-bot:cherry-pick-9300-to-release-8.1
Sep 27, 2024
Merged

fix cast to decimal wrong sign (#9300)#9356
ti-chi-bot[bot] merged 6 commits intopingcap:release-8.1from
ti-chi-bot:cherry-pick-9300-to-release-8.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Aug 26, 2024

This is an automated cherry-pick of #9300

What problem does this PR solve?

Issue Number: close #9301
ref pingcap/tidb#53892

Problem Summary:

cast -0.741(decimal(11, 4)) to decimal(10, 0)

intput Decimal32
    value: -7410
    scale: 4

cast calc process: 
1. calc new value: -7410 / scale_mul(10000) = 0
2. 7410 % 10000 > 5000, so need to round
3. old value is neg, so result should be 0-1 = -1.
    (bug here, should check old value's sign instead new value's sign, because new value canbe zero)

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@guo-shaoge @ti-chi-bot
fix cast to decimal(10, 0)
9c985af 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge @ti-chi-bot
refine case
31be3b1 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge @ti-chi-bot
fix case
4609b56 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge @ti-chi-bot
case
f669ef3 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 26, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 26, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. label Aug 26, 2024
windtalker
windtalker approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 24, 2024
yibin87
yibin87 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 24, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-24 09:02:51.231352622 +0000 UTC m=+1556640.971776553: ☑️ agreed by windtalker.
  • 2024-09-24 09:06:35.495944642 +0000 UTC m=+1556865.236368581: ☑️ agreed by yibin87.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 27, 2024

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@guo-shaoge
Copy link
Contributor

guo-shaoge commented Sep 27, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 08595f4 into pingcap:release-8.1 Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@yibin87 yibin87 yibin87 approved these changes

Assignees

@guo-shaoge guo-shaoge

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @guo-shaoge @windtalker @yibin87