Skip to content

Disagg: Reduce the number of threads created for handling disaggregated requests (#9335)#9346

Closed
ti-chi-bot wants to merge 3 commits intopingcap:release-8.1from
ti-chi-bot:cherry-pick-9335-to-release-8.1
Closed

Disagg: Reduce the number of threads created for handling disaggregated requests (#9335)#9346
ti-chi-bot wants to merge 3 commits intopingcap:release-8.1from
ti-chi-bot:cherry-pick-9335-to-release-8.1

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9335

What problem does this PR solve?

Issue Number: close #9334

Problem Summary:

In StorageDisaggregated, the call chain buildReadTaskForWriteNode => buildReadTaskForWriteNodeTable => buildRNReadSegmentTask will create a DynamicThreadManager in each functions.

The total number of threads used in StorageDisaggregated is about request_count * batch_cop_tasks.size() * resp.tables().size() * table.segments().size().

What is changed and how it works?

Use IOThreadPool to replace DynamicThreadManager.

If the number of tasks is greater than the number of threads, DynamicThreadManager will create new threads to handle these tasks, while IOThreadPool will make these tasks queue up.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Reduce the number of threads created for handling disaggregated requests

减少处理存算分离请求创建的线程数

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Aug 23, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jinhelin, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 27, 2024
@JinheLin
Copy link
Contributor

JinheLin commented Sep 3, 2024

Replace by #9402

@JinheLin JinheLin closed this Sep 3, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Sep 4, 2024
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants