Skip to content

Pipeline: refactor the extra time calculation in explain analyze (#8987)#9340

Merged
ti-chi-bot[bot] merged 8 commits intopingcap:release-8.1from
ti-chi-bot:cherry-pick-8987-to-release-8.1
Sep 4, 2024
Merged

Pipeline: refactor the extra time calculation in explain analyze (#8987)#9340
ti-chi-bot[bot] merged 8 commits intopingcap:release-8.1from
ti-chi-bot:cherry-pick-8987-to-release-8.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Aug 21, 2024

This is an automated cherry-pick of #8987

What problem does this PR solve?

Issue Number: close #8962

Problem Summary:

What is changed and how it works?

  1. refactor the wait_for_notify_time of operator by introducing PipelineExec::wait_for_notify and use Operator::notify to collect the waiting_for_notify time
  2. Distribute the pending time evenly across all operators.
  3. add exec_context.getQueryProfileInfo().toJson() to mpp tracing log

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Aug 21, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 21, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 21, 2024
@windtalker
Copy link
Contributor

windtalker commented Aug 22, 2024

@SeaRise can you help confirm if it is safe to cherry pick this pr to release-8.1 branch?

@SeaRise
Copy link
Contributor

SeaRise commented Aug 22, 2024

/cc @SeaRise

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 22, 2024

@SeaRise: GitHub didn't allow me to request PR reviews from the following users: SeaRise.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @SeaRise

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SeaRise
SeaRise approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 22, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, SeaRise

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,SeaRise]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 22, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-21 07:11:23.605351061 +0000 UTC m=+335878.739801172: ☑️ agreed by JaySon-Huang.
  • 2024-08-22 06:43:35.885269881 +0000 UTC m=+420611.019720003: ☑️ agreed by SeaRise.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 4, 2024
@windtalker
Copy link
Contributor

windtalker commented Sep 4, 2024

/run-all-tests

@windtalker
Copy link
Contributor

windtalker commented Sep 4, 2024

/rebuild

@ti-chi-bot ti-chi-bot bot merged commit 0d9d397 into pingcap:release-8.1 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

+1 more reviewer

@SeaRise SeaRise SeaRise approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @windtalker @SeaRise @JaySon-Huang