storage: Support vector index and ANN hint#9261
Merged
ti-chi-bot[bot] merged 12 commits intopingcap:feature/vector-indexfrom Aug 12, 2024
Merged
storage: Support vector index and ANN hint#9261ti-chi-bot[bot] merged 12 commits intopingcap:feature/vector-indexfrom
ti-chi-bot[bot] merged 12 commits intopingcap:feature/vector-indexfrom
Conversation
Signed-off-by: Wish <breezewish@outlook.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Contributor
Author
|
/build |
JaySon-Huang
reviewed
Aug 6, 2024
Co-authored-by: JaySon <tshent@qq.com>
JaySon-Huang
reviewed
Aug 6, 2024
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
breezewish
approved these changes
Aug 7, 2024
Lloyd-Pottiger
commented
Aug 7, 2024
Comment on lines
-183
to
-189
| #if 1 | ||
| writeColumnStatToBuffer(tmp_buffer), | ||
| #else | ||
| // ExtendColumnStat is not enabled yet because it cause downgrade compatibility, wait | ||
| // to be released with other binary format changes. | ||
| writeExtendColumnStatToBuffer(tmp_buffer), | ||
| #endif |
Contributor
Author
There was a problem hiding this comment.
@JaySon-Huang Please confirm those changes.
Contributor
There was a problem hiding this comment.
Confirm. It is OK because we need to bump the STORAGE_FORMAT_CURRENT in later PR
JaySon-Huang
approved these changes
Aug 12, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breezewish, JaySon-Huang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #9032
Problem Summary:
What is changed and how it works?
Pick https://github.com/tidbcloud/tiflash-cse/pull/156, https://github.com/tidbcloud/tiflash-cse/pull/162, https://github.com/tidbcloud/tiflash-cse/pull/163, https://github.com/tidbcloud/tiflash-cse/pull/164
Changes:
ExtendColumnStatin DMFile meta for storing the meta of vector indexDMFileWriter::addStreamswill generate the index while writing down a new DMFileVectorIndexgenerates the index by HNSW algorithmDMFileBlockInputStreamBuilderwill try to generate aDMFileWithVectorIndexBlockInputStream. If vector index is unavailable, the read fallback to normal read and filter. InDMFileWithVectorIndexBlockInputStream, itTODO:
tiflash/dbms/src/Storages/DeltaMerge/File/DMFileBlockInputStream.cpp
Lines 145 to 147 in 9fab7b2
Check List
Tests
Side effects
Documentation
Release note