Implement hash join v2(inner join)#9191
Conversation
Signed-off-by: gengliqi <gengliqiii@gmail.com>
Signed-off-by: gengliqi <gengliqiii@gmail.com>
Signed-off-by: gengliqi <gengliqiii@gmail.com>
Signed-off-by: gengliqi <gengliqiii@gmail.com>
Signed-off-by: gengliqi <gengliqiii@gmail.com>
Signed-off-by: gengliqi <gengliqiii@gmail.com>
Signed-off-by: gengliqi <gengliqiii@gmail.com>
| Block HashJoin::handleOtherConditions(size_t stream_index) | ||
| { | ||
| auto & wd = probe_workers_data[stream_index]; | ||
| non_equal_conditions.other_cond_expr->execute(wd.result_block); |
There was a problem hiding this comment.
question: HashJoinV2 still needs to materialize all columns and compute other conditions, instead of only materialize columns that needed by other condition?
There was a problem hiding this comment.
Yes, I will do that later.
Signed-off-by: gengliqi <gengliqiii@gmail.com>
Signed-off-by: gengliqi <gengliqiii@gmail.com>
[LGTM Timeline notifier]Timeline:
|
|
@gengliqi: You cannot manually add or delete the reviewing state labels, only I and the tursted members have permission to do so. DetailsIn response to adding label named approved. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: gengliqi <gengliqiii@gmail.com>
ad6f1fb to
98dbafa
Compare
Signed-off-by: gengliqi <gengliqiii@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guo-shaoge, windtalker, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #9060
Problem Summary:
This PR implements hash join v2(inner join).
The hash join v2 will be enabled if
settings.enable_hash_join_v2is trueWith the below system variables.
TPC-H Q9: 5.09s vs 3.63s, 40% improvement
Hash Join V1 5.09s
Hash Join V2 3.63s
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note