Skip to content

ddl: Refactor for fixing unstable drop table (#8421)#8431

Closed
ti-chi-bot wants to merge 4 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-8421-to-release-7.5
Closed

ddl: Refactor for fixing unstable drop table (#8421)#8431
ti-chi-bot wants to merge 4 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-8421-to-release-7.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 28, 2023

This is an automated cherry-pick of #8421

What problem does this PR solve?

Issue Number: ref #8395

Problem Summary:

What is changed and how it works?

  • Abstract class DatabaseInfoCache to wrap the logic about the database info cache in TiDBSchemaSyncer and SchemaBuilder
  • Replace TiDBSchemaSyncer::findDatabaseIDAndTableID by TableIDMap:: findDatabaseIDAndLogicalTableID
  • Simplify getting canonical name in SchemaSyncService to remove useless code
  • Remove useless code SchemaBuilder-internal.h

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 28, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 28, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 28, 2023
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Nov 28, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gengliqi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Nov 30, 2023

merged into #8444

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JaySon-Huang JaySon-Huang

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ti-chi-bot @JaySon-Huang