Skip to content

ddl: Fix frequent schema GC under multi tenant (#8248)#8266

Merged
ti-chi-bot[bot] merged 7 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-8248-to-release-7.5
Oct 27, 2023
Merged

ddl: Fix frequent schema GC under multi tenant (#8248)#8266
ti-chi-bot[bot] merged 7 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-8248-to-release-7.5

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8248

What problem does this PR solve?

Issue Number: close #8256

Problem Summary:

Previously, the last_gc_safepoint does not distinguish between keyspaces under multi tenant. Which make the Schema GC run repeadtly

What is changed and how it works?

  • Keep the last_gc_safepoint for each keyspace
  • Add some logging about the tombstone timestamp when a table get physically dropped in TiFlash

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Oct 27, 2023
@JaySon-Huang
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 27, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 27, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 27, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Lloyd-Pottiger,hongyunyan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 27, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-27 07:26:32.021923448 +0000 UTC m=+2592389.609033594: ☑️ agreed by Lloyd-Pottiger.
  • 2023-10-27 07:27:14.057515467 +0000 UTC m=+2592431.644625612: ☑️ agreed by hongyunyan.

@ti-chi-bot ti-chi-bot bot merged commit 443b118 into pingcap:release-7.5 Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants