Skip to content

ddl: Fix corner case when multiple region creates one table simultaneously (#8229)#8238

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-8229-to-release-7.5
Oct 27, 2023
Merged

ddl: Fix corner case when multiple region creates one table simultaneously (#8229)#8238
ti-chi-bot[bot] merged 3 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-8229-to-release-7.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Oct 25, 2023

This is an automated cherry-pick of #8229

What problem does this PR solve?

Issue Number: close #8217

Problem Summary:

What is changed and how it works?

Fix the inner action order among create table to guaranteed atomicity.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix a crash issue when multiple Regions of the same table are added to TiFlash concurrently

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Oct 25, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 25, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 25, 2023
JaySon-Huang
JaySon-Huang approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 25, 2023
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Oct 25, 2023

/run-all-tests

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan, JaySon-Huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,hongyunyan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 27, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-25 08:29:25.097683943 +0000 UTC m=+2423362.684794088: ☑️ agreed by JaySon-Huang.
  • 2023-10-27 07:28:07.293600228 +0000 UTC m=+2592484.880710373: ☑️ agreed by hongyunyan.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 27, 2023

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit b6b2d1e into pingcap:release-7.5 Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@hongyunyan hongyunyan hongyunyan approved these changes

Assignees

@hongyunyan hongyunyan

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @JaySon-Huang @hongyunyan