Skip to content

Fix memory leak in ReceivedMessageQueue#7963

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
windtalker:fix_memory_leak_in_received_message_queue
Aug 18, 2023
Merged

Fix memory leak in ReceivedMessageQueue#7963
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
windtalker:fix_memory_leak_in_received_message_queue

Conversation

@windtalker
Copy link
Contributor

@windtalker windtalker commented Aug 18, 2023

What problem does this PR solve?

Issue Number: close #7951

Problem Summary:

What is changed and how it works?

The root cause is object stored in PODArray must be POD object, and clearly LooseBoundedMessageQueue is not a POD object

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@windtalker
save work
ac50965 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 18, 2023
SeaRise
SeaRise approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 18, 2023
yibin87
yibin87 approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 18, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-18 01:36:31.995442344 +0000 UTC m=+854156.544458316: ☑️ agreed by SeaRise.
  • 2023-08-18 01:39:03.10411656 +0000 UTC m=+854307.653132547: ☑️ agreed by yibin87.

@SeaRise
Copy link
Contributor

SeaRise commented Aug 18, 2023

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

  • Currently the CI jobs are not prow job style, we need it to notify Jenkins server to run them.
  • If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SeaRise, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@windtalker
Copy link
Contributor Author

windtalker commented Aug 18, 2023

/run-all-tests

@windtalker
Copy link
Contributor Author

windtalker commented Aug 18, 2023

/rebuild

@windtalker
Copy link
Contributor Author

windtalker commented Aug 18, 2023

/run-integration-test

@ti-chi-bot ti-chi-bot bot merged commit 42d357b into pingcap:master Aug 18, 2023
@windtalker windtalker deleted the fix_memory_leak_in_received_message_queue branch September 20, 2023 00:25
@SeaRise SeaRise mentioned this pull request Sep 27, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yibin87 yibin87 yibin87 approved these changes

+1 more reviewer

@SeaRise SeaRise SeaRise approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Some asan fail because of ReceivedMessageQueue

3 participants

@windtalker @SeaRise @yibin87