Optimize DDLGuard to remove useless two-level mapping#7699
Optimize DDLGuard to remove useless two-level mapping#7699ti-chi-bot[bot] merged 9 commits intopingcap:masterfrom
Conversation
|
/rebuild |
| context.getDDLGuard(drop.table, | ||
| "Table " + database_name + "." + drop.table + " is dropping or detaching right now")); |
There was a problem hiding this comment.
use fmt::format instead
| to.table_name, | ||
| "Some table right now is being renamed to " + to.database_name + "." + to.table_name)); | ||
| context.getDDLGuard(to.table_name, | ||
| "Some table right now is being renamed to " + to.database_name + "." + to.table_name)); |
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, lidezhu, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/merge |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-integration-test |
|
@hongyunyan: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
…iflash into hongyunyan_ddlguard
|
/run-all-tests |
|
/run-unit-test |
|
/run-all-tests |
|
/run-integration-test |
What problem does this PR solve?
Issue Number: close #7636
Problem Summary:
What is changed and how it works?
We don't need the two-level mapping database -> table -> exception_message for DDLGuard, because the table(with table_id and keyspace_id) is a global unique.
Thus, we optimize it to simplify the code.
Check List
Tests
Side effects
Documentation
Release note