Support TiFlash Metrics with keyspace info and adjust schema metrics#7679
Merged
ti-chi-bot[bot] merged 9 commits intopingcap:masterfrom Jun 20, 2023
Merged
Conversation
Contributor
Author
Contributor
Author
|
/run-all-tests |
|
|
||
| const auto old_mapped_tbl_name = storage->getTableName(); | ||
| GET_METRIC(tiflash_schema_internal_ddl_count, type_rename_column).Increment(); | ||
| GET_KEYSPACE_METRIC(tiflash_schema_internal_ddl_count, type_modify_column, keyspace_id).Increment(); |
Contributor
There was a problem hiding this comment.
this should be type_rename_table?
metrics/grafana/tiflash_summary.json
Outdated
| "format": "time_series", | ||
| "intervalFactor": 1, | ||
| "legendFormat": "{{type}}", | ||
| "legendFormat": "{{type-keyspace}}", |
Contributor
There was a problem hiding this comment.
should it be
Suggested change
| "legendFormat": "{{type-keyspace}}", | |
| "legendFormat": "{{type}}-{{keyspace}}", |
metrics/grafana/tiflash_summary.json
Outdated
| "format": "time_series", | ||
| "intervalFactor": 1, | ||
| "legendFormat": "{{instance}}", | ||
| "legendFormat": "{{instance-keyspace}}", |
Contributor
Author
|
/run-all-tests |
Contributor
|
/run-all-tests |
1 similar comment
Contributor
Author
|
/run-all-tests |
JaySon-Huang
approved these changes
Jun 20, 2023
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, lidezhu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
Contributor
|
/run-integration-test |
Contributor
|
/run-integration-test |
Contributor
|
/rebuild |
Contributor
|
/run-integration-test |
Contributor
Author
|
/run-all-tests |
Contributor
|
It looks like the metrics for query level should also include keyspace info, such as coprocess and mpp. |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #7640
Problem Summary:
What is changed and how it works?
Now, the grafana for ddl part looks like:
Check List
Tests
Side effects
Documentation
Release note