Skip to content

storage: Accepts a snapshot for segment replaceData API#6385

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
breezewish:wenxuan/replace_data_snapshot
Nov 29, 2022
Merged

storage: Accepts a snapshot for segment replaceData API#6385
ti-chi-bot merged 3 commits intopingcap:masterfrom
breezewish:wenxuan/replace_data_snapshot

Conversation

@breezewish
Copy link
Member

@breezewish breezewish commented Nov 29, 2022

Signed-off-by: Wish breezewish@outlook.com

What problem does this PR solve?

Issue Number: ref #5237

Problem Summary:

What is changed and how it works?

This PR is extracted from #6378

  1. Changed dangerouslyReplaceData to be replaceData. Now it accepts an optional snapshot parameter, so that it becomes safe.

    When snapshot parameter is specified, everything data in the snapshot will be replaced, and everything after the snapshot will be kept.

    When snapshot is not specified, everything will be replaced.

    In this PR, we will not utilize this new feature. It will be used in storage: handle IngestSST using segment split #6378.

  2. Segment::replaceData API does not create a ref file by itself now. The ref file is now created by the caller, in the DeltaMergeStore_Ingest.cpp.

  3. Add unit tests for the new replaceData API.

  4. Add randomized tests for the new replaceData. We randomly create a snapshot, and after some iterations (for example, possibly some writes) we will invoke the replaceData. We check whether the write-after-snapshot are preserved.

  5. DeltaMergeStore::dangerouslyReplaceData is still preserved. It will be dropped in the next PR.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: Wish <breezewish@outlook.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 29, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 29, 2022
@breezewish
Copy link
Member Author

/run-all-tests

Copy link
Contributor

@lidezhu lidezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 29, 2022
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 29, 2022
@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 52cf4be

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 29, 2022
@ti-chi-bot
Copy link
Member

@breezewish: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit f57ec4b into pingcap:master Nov 29, 2022
@breezewish breezewish deleted the wenxuan/replace_data_snapshot branch March 21, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants