Skip to content

Fix two DDL bugs on hotfix branch#6042

Merged
JaySon-Huang merged 3 commits intopingcap:release-5.4-20220531from
JaySon-Huang:hotfix_5859
Oct 31, 2022
Merged

Fix two DDL bugs on hotfix branch#6042
JaySon-Huang merged 3 commits intopingcap:release-5.4-20220531from
JaySon-Huang:hotfix_5859

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Sep 27, 2022

What problem does this PR solve?

Issue Number: close #5154, close #5859

Problem Summary:

cherry-pick two bug fixes for DDL:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • flowbehappy
  • hongyunyan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Sep 27, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 27, 2022
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 27, 2022
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Sep 27, 2022

/build

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Sep 27, 2022

/cc @hongyunyan @lidezhu @flowbehappy

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 27, 2022
hongyunyan
hongyunyan approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@hongyunyan hongyunyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 27, 2022
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Oct 14, 2022

close as the user plan to upgrade to v5.4.3 which include these fixes

@JaySon-Huang JaySon-Huang deleted the hotfix_5859 branch October 14, 2022 08:08
@JaySon-Huang JaySon-Huang restored the hotfix_5859 branch October 31, 2022 08:42
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Oct 31, 2022

/reopen

@ti-chi-bot ti-chi-bot reopened this Oct 31, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 31, 2022

@JaySon-Huang: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JaySon-Huang JaySon-Huang merged commit f0d54d6 into pingcap:release-5.4-20220531 Oct 31, 2022
@JaySon-Huang JaySon-Huang deleted the hotfix_5859 branch October 31, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flowbehappy flowbehappy flowbehappy approved these changes

@hongyunyan hongyunyan hongyunyan approved these changes

@lidezhu lidezhu Awaiting requested review from lidezhu

Assignees

No one assigned

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JaySon-Huang @ti-chi-bot @flowbehappy @hongyunyan @VelocityLight