Skip to content

Remove useless gcov utils scripts for GCC#6024

Merged
ti-chi-bot merged 5 commits intopingcap:masterfrom
solotzg:remove-uselesscode
Sep 26, 2022
Merged

Remove useless gcov utils scripts for GCC#6024
ti-chi-bot merged 5 commits intopingcap:masterfrom
solotzg:remove-uselesscode

Conversation

@solotzg
Copy link
Contributor

@solotzg solotzg commented Sep 26, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4909

Problem Summary:

We do not support gcc in official CI/CD process. Remove such scripts.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@solotzg
wip
55bcc73 
Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
@solotzg
remove
4459562 
Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 26, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • breezewish

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 26, 2022
@solotzg
Copy link
Contributor Author

solotzg commented Sep 26, 2022

/run-unit-test

@solotzg
Copy link
Contributor Author

solotzg commented Sep 26, 2022

/rebuild

@solotzg solotzg changed the title Remove useless utils scripts for GCC Remove useless gcov utils scripts for GCC Sep 26, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Sep 26, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18351      7512             59.06%    214676  77162        64.06%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 26, 2022
@solotzg solotzg requested a review from breezewish September 26, 2022 08:44
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 26, 2022
@breezewish
Copy link
Member

breezewish commented Sep 26, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 26, 2022

@breezewish: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 26, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 4459562

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 26, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Sep 26, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18351      7514             59.05%    214676  77236        64.02%

full coverage report (for internal network access only)

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 26, 2022

@solotzg: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 26, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18358      7513             59.08%    214851  77182        64.08%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 676699c into pingcap:master Sep 26, 2022
@solotzg solotzg mentioned this pull request Sep 26, 2022
Open
6 tasks
@solotzg solotzg deleted the remove-uselesscode branch September 26, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breezewish breezewish breezewish approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@fuzhe1989 fuzhe1989 Awaiting requested review from fuzhe1989

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@solotzg @ti-chi-bot @sre-bot @breezewish @JaySon-Huang