Skip to content

Disable folly memcpy as default memcpy (#5996)#6001

Merged
ti-chi-bot merged 2 commits intopingcap:release-6.3from
ti-chi-bot:cherry-pick-5996-to-release-6.3
Sep 22, 2022
Merged

Disable folly memcpy as default memcpy (#5996)#6001
ti-chi-bot merged 2 commits intopingcap:release-6.3from
ti-chi-bot:cherry-pick-5996-to-release-6.3

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Sep 22, 2022 •
edited by solotzg
Loading

This is an automated cherry-pick of #5996

What problem does this PR solve?

Issue Number: close #5949

What is changed and how it works?

For b232bcd, the result is

20220922,constant,incremental,0.49,200478,1747997

Before this PR

+ ./tiflash dtworkload --write_key_distribution=incremental --verify_round=20
20220922,constant,incremental,0.53,188916,1720491

After this PR

+ ./tiflash dtworkload --write_key_distribution=incremental --verify_round=20
20220922,constant,incremental,0.44,207025,1685328

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 22, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Sep 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ywqzzy
  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.3 type/enhancement The issue or PR belongs to an enhancement. labels Sep 22, 2022
@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 22, 2022
zanmato1984
zanmato1984 approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 22, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 22, 2022
@solotzg
Copy link
Contributor

solotzg commented Sep 22, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Sep 22, 2022

@solotzg: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Sep 22, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 681b441

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 22, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Sep 22, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18865      8116             56.98%    219622  83591        61.94%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit a05f9e7 into pingcap:release-6.3 Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

+1 more reviewer

@ywqzzy ywqzzy ywqzzy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@solotzg solotzg

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.3 type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @solotzg @sre-bot @zanmato1984 @ywqzzy