Skip to content

tests: Fix RegionBlockReaderTest helper functions (#5899)#5923

Closed
ti-chi-bot wants to merge 1 commit intopingcap:release-5.3from
ti-chi-bot:cherry-pick-5899-to-release-5.3
Closed

tests: Fix RegionBlockReaderTest helper functions (#5899)#5923
ti-chi-bot wants to merge 1 commit intopingcap:release-5.3from
ti-chi-bot:cherry-pick-5899-to-release-5.3

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Sep 16, 2022

This is an automated cherry-pick of #5899

Signed-off-by: JaySon-Huang tshent@qq.com

What problem does this PR solve?

Issue Number: ref #5859

Problem Summary:
The helper functions in RegionBlockReaderTestFixture is buggy when testing with primary key columns.

What is changed and how it works?

Fix the testing helper functions.
A pre-split PR for #5879

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@JaySon-Huang @ti-chi-bot
This is an automated cherry-pick of pingcap#5899
5ba942d 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 16, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Sep 16, 2022

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Sep 16, 2022

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-5.3 labels Sep 16, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 16, 2022
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Sep 16, 2022

Close as the code change too much before merging the PR "Improve the efficiency of decode process of rows to columns"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JaySon-Huang JaySon-Huang

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-5.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ti-chi-bot @JaySon-Huang