Test: refine Executor Unit Test#5889
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
/run-unit-test |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
| .build(context); | ||
| result.emplace_back(toNullableVec<String>({"b0b", "c0c", "d0d", {}, "f0f", "g0g", "h0h", {}})); | ||
| executeWithConcurrency(request, result); | ||
| executeAndAssertColumnsEqual(request, result); |
There was a problem hiding this comment.
How can we print the line number in gtest_xxx.cpp when test failed？
There was a problem hiding this comment.
now the fail msg will be
Value of: assert_func(executeStreams(request, concurrency))
Actual: false (
Columns rows mismatch
expected_rows: 0
actual_rows: 1)
Expected: true
test info:
file: /data1/huanghaisheng/git-repo/tiflash/dbms/src/Flash/tests/gtest_limit_executor.cpp
line: 50
test_case_name: ExecutorLimitTestRunner
test_func_name: Limit
enable_planner: false
concurrency: 1
block_size: 1
dag_request:
limit_1 | 1
table_scan_0 | {<0, String>}
| std::function<void(const ColumnsWithTypeAndName &)> assert_func) | ||
| { | ||
| WRAP_FOR_DIS_ENABLE_PLANNER_BEGIN | ||
| std::vector<size_t> concurrencies{1, 2, 10}; |
There was a problem hiding this comment.
Maybe we should provide some ways to set the concurrency policy, such as number of concurrencies or degree of concurrency, by users.
There was a problem hiding this comment.
I think they can use executeStream(dagrequest, concurrency) directly.
Specifying a specific degree of concurrency is a rare requirement.
|
lgtm |
|
/merge |
|
@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 2cf249d |
|
@SeaRise: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
What problem does this PR solve?
Issue Number: ref #4609
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note