Skip to content

Test: wrap some API for aggregation function tests#5787

Closed
ywqzzy wants to merge 10 commits intopingcap:masterfrom
ywqdev:agg_test_framework
Closed

Test: wrap some API for aggregation function tests#5787
ywqzzy wants to merge 10 commits intopingcap:masterfrom
ywqdev:agg_test_framework

Conversation

@ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Sep 5, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4609

Problem Summary:

What is changed and how it works?

Add executeAggFunctionAndAssert to test agg functions on given column.
Add executeGroupByAndAssert to test group by on given columns.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 5, 2022

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 5, 2022
@ywqzzy ywqzzy marked this pull request as ready for review September 5, 2022 06:51
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2022
@ywqzzy ywqzzy mentioned this pull request Sep 5, 2022
Closed
54 tasks
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 5, 2022

/run-all-tests

@ywqzzy ywqzzy force-pushed the agg_test_framework branch from b1b5878 to 604a5c7 Compare September 5, 2022 09:55
@ywqzzy ywqzzy added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 17, 2022

@ywqzzy: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2022
@ywqzzy ywqzzy closed this Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ywqzzy @ti-chi-bot