Skip to content

Enhance join test framework with conditional expressions#5543

Merged
ti-chi-bot merged 12 commits intopingcap:masterfrom
Willendless:enhance-join-test-framework
Aug 8, 2022
Merged

Enhance join test framework with conditional expressions#5543
ti-chi-bot merged 12 commits intopingcap:masterfrom
Willendless:enhance-join-test-framework

Conversation

@Willendless
Copy link
Contributor

@Willendless Willendless commented Aug 4, 2022

What problem does this PR solve?

Issue Number: close #5351

Problem Summary:

What is changed and how it works?

  • add conditional expression support for join executor test
  • refine Mock::Join structure: use ASTs for join_cols and all conditional expressions
  • resolve legacy test support

As for design details, please refer to #5351.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 4, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 4, 2022
@Willendless
Copy link
Contributor Author

Willendless commented Aug 4, 2022

/run-unit-test

@sre-bot
Copy link
Collaborator

sre-bot commented Aug 4, 2022

Coverage for changed files

Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/astToExecutor.cpp                          591               145    75.47%          57                 4    92.98%        1586               375    76.36%         590               196    66.78%
Debug/astToExecutor.h                             30                 8    73.33%          22                 4    81.82%          48                12    75.00%           8                 5    37.50%
Flash/tests/gtest_collation.cpp                  125                37    70.40%          10                 0   100.00%         349                57    83.67%          82                28    65.85%
Flash/tests/gtest_interpreter.cpp                122                42    65.57%           7                 0   100.00%         557                 0   100.00%          24                24     0.00%
Flash/tests/gtest_join_executor.cpp              113                56    50.44%          12                 0   100.00%         351                 0   100.00%          44                32    27.27%
Flash/tests/gtest_split_tasks.cpp                 43                14    67.44%           3                 0   100.00%         100                 0   100.00%          16                 8    50.00%
TestUtils/mockExecutor.cpp                        74                 3    95.95%          42                 1    97.62%         268                24    91.04%          36                 2    94.44%
TestUtils/mockExecutor.h                          11                 4    63.64%          11                 4    63.64%          23                 6    73.91%           0                 0         -
TestUtils/tests/gtest_mock_executors.cpp         142                70    50.70%          11                 0   100.00%         215                 0   100.00%          40                40     0.00%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                           1251               379    69.70%         175                13    92.57%        3497               474    86.45%         840               335    60.12%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18927      9422             50.22%    213960  95025        55.59%

full coverage report (for internal network access only)

@Willendless
Copy link
Contributor Author

Willendless commented Aug 4, 2022

/run-integration-test

@Willendless
Copy link
Contributor Author

Willendless commented Aug 4, 2022

/cc @ywqzzy @SeaRise

@ti-chi-bot ti-chi-bot requested review from SeaRise and ywqzzy August 4, 2022 17:56
SeaRise
SeaRise reviewed Aug 5, 2022
View reviewed changes
@Willendless
Copy link
Contributor Author

Willendless commented Aug 7, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Aug 7, 2022

Coverage for changed files

Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/astToExecutor.cpp                          591               145    75.47%          57                 4    92.98%        1586               375    76.36%         590               196    66.78%
Debug/astToExecutor.h                             30                 8    73.33%          22                 4    81.82%          48                12    75.00%           8                 5    37.50%
Flash/tests/gtest_collation.cpp                  125                37    70.40%          10                 0   100.00%         349                57    83.67%          82                28    65.85%
Flash/tests/gtest_interpreter.cpp                122                42    65.57%           7                 0   100.00%         557                 0   100.00%          24                24     0.00%
Flash/tests/gtest_join_executor.cpp              113                56    50.44%          12                 0   100.00%         351                 0   100.00%          44                32    27.27%
Flash/tests/gtest_split_tasks.cpp                 43                14    67.44%           3                 0   100.00%         100                 0   100.00%          16                 8    50.00%
TestUtils/mockExecutor.cpp                        74                 3    95.95%          42                 1    97.62%         268                24    91.04%          36                 2    94.44%
TestUtils/mockExecutor.h                          12                 4    66.67%          12                 4    66.67%          26                 6    76.92%           0                 0         -
TestUtils/tests/gtest_mock_executors.cpp         142                70    50.70%          11                 0   100.00%         215                 0   100.00%          40                40     0.00%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                           1252               379    69.73%         176                13    92.61%        3500               474    86.46%         840               335    60.12%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18928      9420             50.23%    213963  95002        55.60%

full coverage report (for internal network access only)

SeaRise
SeaRise approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 8, 2022
ywqzzy
ywqzzy approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@ywqzzy ywqzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 8, 2022
@ywqzzy
Copy link
Contributor

ywqzzy commented Aug 8, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 8, 2022

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 8, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b63d8d9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 8, 2022
@SeaRise
Copy link
Contributor

SeaRise commented Aug 8, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 8, 2022
@Willendless
Copy link
Contributor Author

Willendless commented Aug 8, 2022

/run-all-tests

@SeaRise
Copy link
Contributor

SeaRise commented Aug 8, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 8, 2022

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 8, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: d5aba6d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 8, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 8, 2022

@Willendless: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Aug 8, 2022

Coverage for changed files

Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/astToExecutor.cpp                          591               144    75.63%          57                 3    94.74%        1586               372    76.54%         590               196    66.78%
Debug/astToExecutor.h                             30                 8    73.33%          22                 4    81.82%          48                12    75.00%           8                 5    37.50%
Flash/tests/gtest_collation.cpp                  125                37    70.40%          10                 0   100.00%         349                57    83.67%          82                28    65.85%
Flash/tests/gtest_compute_server.cpp              39                14    64.10%           3                 0   100.00%          69                 0   100.00%          12                 8    33.33%
Flash/tests/gtest_interpreter.cpp                122                42    65.57%           7                 0   100.00%         557                 0   100.00%          24                24     0.00%
Flash/tests/gtest_join_executor.cpp              113                56    50.44%          12                 0   100.00%         351                 0   100.00%          44                32    27.27%
Flash/tests/gtest_split_tasks.cpp                 43                14    67.44%           3                 0   100.00%         100                 0   100.00%          16                 8    50.00%
TestUtils/mockExecutor.cpp                        74                 3    95.95%          42                 1    97.62%         268                24    91.04%          36                 2    94.44%
TestUtils/mockExecutor.h                          12                 4    66.67%          12                 4    66.67%          26                 6    76.92%           0                 0         -
TestUtils/tests/gtest_mock_executors.cpp         142                70    50.70%          11                 0   100.00%         215                 0   100.00%          40                40     0.00%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                           1291               392    69.64%         179                12    93.30%        3569               471    86.80%         852               343    59.74%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
19039      9210             51.63%    215883  93638        56.63%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit d8fae61 into pingcap:master Aug 8, 2022
@ywqzzy ywqzzy mentioned this pull request Aug 25, 2022
Closed
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@SeaRise SeaRise SeaRise approved these changes

@ywqzzy ywqzzy ywqzzy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support more types of Join to test

5 participants

@Willendless @ti-chi-bot @sre-bot @ywqzzy @SeaRise