refine FlashService by ywqzzy · Pull Request #5471 · pingcap/tiflash

ywqzzy · 2022-07-26T09:05:23Z

What problem does this PR solve?

Issue Number: ref #4609

Problem Summary:

What is changed and how it works?

Do not pass IServer into FlashService.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

ti-chi-bot · 2022-07-26T09:05:24Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

LittleFall
gengliqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ywqzzy · 2022-07-26T09:06:01Z

/run-all-tests

sre-bot · 2022-07-26T09:24:53Z

Coverage for changed files

Filename                                                                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Flash/FlashService.h           4                 4     0.00%           4                 4     0.00%          14                14     0.00%           0                 0         -
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                              4                 4     0.00%           4                 4     0.00%          14                14     0.00%           0                 0         -

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18827      9436             49.88%    214683  95393        55.57%

full coverage report (for internal network access only)

sre-bot · 2022-07-26T09:37:02Z

Coverage for changed files

Filename                                                                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Flash/FlashService.h           4                 4     0.00%           4                 4     0.00%          14                14     0.00%           0                 0         -
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                              4                 4     0.00%           4                 4     0.00%          14                14     0.00%           0                 0         -

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18619      9408             49.47%    212190  95011        55.22%

full coverage report (for internal network access only)

dbms/src/Flash/FlashService.h

gengliqi · 2022-07-26T09:46:28Z

dbms/src/Flash/FlashService.h

    static constexpr int EstablishMPPConnectionApiID = 48;
-    explicit AsyncFlashService(IServer & server)
-        : FlashService(server)
+    explicit AsyncFlashService(const TiFlashSecurityConfig & security_config_, Context & context_)


Suggested change

explicit AsyncFlashService(const TiFlashSecurityConfig & security_config_, Context & context_)

AsyncFlashService(const TiFlashSecurityConfig & security_config_, Context & context_)

gengliqi

LGTM

SeaRise

LGTM

ywqzzy · 2022-07-26T10:10:47Z

/merge

ti-chi-bot · 2022-07-26T10:10:48Z

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-07-26T10:10:50Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 21cce8b

fuzhe1989 · 2022-07-26T11:05:14Z

dbms/src/Flash/FlashService.cpp

-    , security_config(server_.securityConfig())
+FlashService::FlashService(const TiFlashSecurityConfig & security_config_, Context & context_)
+    : security_config(security_config_)
+    , m_context(context_)


m_context is not recommended by ClickHouse's coding style.

sre-bot · 2022-07-26T20:07:03Z

Coverage for changed files

Filename                                                                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Flash/FlashService.h           4                 4     0.00%           4                 4     0.00%          14                14     0.00%           0                 0         -
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                              4                 4     0.00%           4                 4     0.00%          14                14     0.00%           0                 0         -

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18827      9432             49.90%    214683  95355        55.58%

full coverage report (for internal network access only)

…uple_flashService

ywqzzy · 2022-07-27T02:01:17Z

/merge

ti-chi-bot · 2022-07-27T02:01:18Z

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-07-27T02:01:20Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: f263b06

sre-bot · 2022-07-27T02:18:55Z

Coverage for changed files

Filename                                                                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Flash/FlashService.h           4                 4     0.00%           4                 4     0.00%          14                14     0.00%           0                 0         -
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                              4                 4     0.00%           4                 4     0.00%          14                14     0.00%           0                 0         -

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18827      9436             49.88%    214682  95392        55.57%

full coverage report (for internal network access only)

ywqzzy added 3 commits July 26, 2022 16:59

refine.

14b993a

update.

c1d2047

update.

c38ee21

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 26, 2022

ywqzzy requested review from SeaRise and gengliqi July 26, 2022 09:05

LittleFall approved these changes Jul 26, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 26, 2022

gengliqi reviewed Jul 26, 2022

View reviewed changes

address comments.

c6fd0a2

ywqzzy force-pushed the decouple_flashService branch from 7571729 to c6fd0a2 Compare July 26, 2022 09:49

ywqzzy requested a review from gengliqi July 26, 2022 09:50

gengliqi approved these changes Jul 26, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 26, 2022

SeaRise approved these changes Jul 26, 2022

View reviewed changes

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 26, 2022

fuzhe1989 reviewed Jul 26, 2022

View reviewed changes

ywqzzy added 2 commits July 27, 2022 07:50

Merge branch 'master' of https://github.com/pingcap/tiflash into deco…

30ec688

…uple_flashService

address comment

a1bf38e

ywqzzy force-pushed the decouple_flashService branch from 21cce8b to a1bf38e Compare July 27, 2022 00:14

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 27, 2022

Merge branch 'master' into decouple_flashService

f263b06

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 27, 2022

ti-chi-bot merged commit 28d3991 into pingcap:master Jul 27, 2022

	explicit AsyncFlashService(const TiFlashSecurityConfig & security_config_, Context & context_)
	AsyncFlashService(const TiFlashSecurityConfig & security_config_, Context & context_)

Conversation

ywqzzy commented Jul 26, 2022

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

ti-chi-bot commented Jul 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ywqzzy commented Jul 26, 2022

Uh oh!

sre-bot commented Jul 26, 2022

Coverage for changed files

Coverage summary

Uh oh!

sre-bot commented Jul 26, 2022

Coverage for changed files

Coverage summary

Uh oh!

Uh oh!

gengliqi Jul 26, 2022

Choose a reason for hiding this comment

Uh oh!

gengliqi left a comment

Choose a reason for hiding this comment

Uh oh!

SeaRise left a comment

Choose a reason for hiding this comment

Uh oh!

ywqzzy commented Jul 26, 2022

Uh oh!

ti-chi-bot commented Jul 26, 2022

Uh oh!

ti-chi-bot commented Jul 26, 2022

Uh oh!

fuzhe1989 Jul 26, 2022

Choose a reason for hiding this comment

Uh oh!

sre-bot commented Jul 26, 2022

Coverage for changed files

Coverage summary

Uh oh!

ywqzzy commented Jul 27, 2022

Uh oh!

ti-chi-bot commented Jul 27, 2022

Uh oh!

ti-chi-bot commented Jul 27, 2022

Uh oh!

sre-bot commented Jul 27, 2022

Coverage for changed files

Coverage summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ti-chi-bot commented Jul 26, 2022 •

edited

Loading