Skip to content

remove tcmalloc#5422

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
lidezhu:remove-tc-malloc
Jul 20, 2022
Merged

remove tcmalloc#5422
ti-chi-bot merged 3 commits intopingcap:masterfrom
lidezhu:remove-tc-malloc

Conversation

@lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Jul 20, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #5425

Problem Summary: tcmalloc is not used by tiflash and can be safely removed.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • Lloyd-Pottiger

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 20, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 20, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 20, 2022

Coverage for changed files

Filename                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/TiFlashBuildInfo.cpp                      18                 0   100.00%          10                 0   100.00%          55                 0   100.00%           0                 0         -
Storages/DeltaMerge/DeltaMergeStore.cpp        1470               532    63.81%          67                 5    92.54%        2061               501    75.69%         856               400    53.27%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                          1488               532    64.25%          77                 5    93.51%        2116               501    76.32%         856               400    53.27%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18594      9570             48.53%    211802  96305        54.53%

full coverage report (for internal network access only)

@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 20, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jul 20, 2022

Coverage for changed files

Filename                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/TiFlashBuildInfo.cpp                      18                 0   100.00%          10                 0   100.00%          55                 0   100.00%           0                 0         -
Storages/DeltaMerge/DeltaMergeStore.cpp        1471               531    63.90%          67                 5    92.54%        2066               498    75.90%         856               400    53.27%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                          1489               531    64.34%          77                 5    93.51%        2121               498    76.52%         856               400    53.27%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18625      9393             49.57%    212355  94906        55.31%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 20, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 20, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 20, 2022

@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 20, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 71d903c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jul 20, 2022

Coverage for changed files

Filename                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/TiFlashBuildInfo.cpp                      18                 0   100.00%          10                 0   100.00%          55                 0   100.00%           0                 0         -
Storages/DeltaMerge/DeltaMergeStore.cpp        1471               531    63.90%          67                 5    92.54%        2066               498    75.90%         856               400    53.27%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                          1489               531    64.34%          77                 5    93.51%        2121               498    76.52%         856               400    53.27%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18625      9389             49.59%    212364  94867        55.33%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 1b81525 into pingcap:master Jul 20, 2022
@lidezhu lidezhu deleted the remove-tc-malloc branch July 20, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@zanmato1984 zanmato1984 Awaiting requested review from zanmato1984

@flowbehappy flowbehappy Awaiting requested review from flowbehappy

@CalvinNeo CalvinNeo Awaiting requested review from CalvinNeo

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

remove useless dependency on tcmalloc

5 participants

@lidezhu @ti-chi-bot @sre-bot @JaySon-Huang @Lloyd-Pottiger